Revise site packages collection search test #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cidrblock
force-pushed
the
fix_revise_sp_test
branch
from
f2d6b31 to
84cfcca
Compare
for more information, see https://pre-commit.ci
audgirka
force-pushed
the
fix_revise_sp_test
branch
from
a2151b3 to
44437e3
Compare
audgirka
approved these changes
Aug 29, 2023
ssbarnea
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revises #318
This test may seem a little expensive, but rather than modify the current runtime enviroment for pytest by installing the collection into one of the current paths, install the collection into a module scoped virtual enviromnet site packages directory.
This will avoid a conflict with a test that is being simultaniously run because the venv is scoped to the module.
The test was moved into it's own file to reflect the scope of the venv fixture and avoid conflict in the future with other tests that may use it.
The return value of
require_collectionwas also modified to provide the version and location of the collection found so it could be used within the test.