Adding collection name requirement checks #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonlhart
requested review from
ssbarnea,
shatakshiiii,
NilashishC and
cidrblock
and removed request for
a team
alisonlhart
force-pushed
the
collection-naming-checks
branch
from
e5f079a to
037719b
Compare
* Adds constant (equal to int 2) for collection name length * Adds a check for collection name length * Adds a check for collection name characters * Adds tests for the new checks
alisonlhart
force-pushed
the
collection-naming-checks
branch
from
037719b to
0580cbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes: #230
Adds checks for collection name requirements and new tests for the new checks.
Examples:
Command:
ansible-creator init COLLECTION.NAMEError output:
Error: Collection name can only contain lower case letters, underscores, and numbers and cannot begin with an underscore.Command:
ansible-creator init na.coError output:
Error: Collection namespace and name must be longer than 2 characters.