Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to scaffold execution environment sample file #340

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Add support to scaffold execution environment sample file #340

merged 3 commits into from
Dec 9, 2024

Conversation

abhikdps
Copy link
Contributor

@abhikdps abhikdps commented Dec 9, 2024

@abhikdps abhikdps added the enhancement New feature or request label Dec 9, 2024
@abhikdps abhikdps self-assigned this Dec 9, 2024
@abhikdps abhikdps requested a review from a team as a code owner December 9, 2024 05:36
@abhikdps abhikdps requested a review from cidrblock December 9, 2024 05:47
cidrblock
cidrblock requested changes Dec 9, 2024
View reviewed changes
src/ansible_creator/arg_parser.py Outdated Show resolved Hide resolved
src/ansible_creator/arg_parser.py Outdated Show resolved Hide resolved
src/ansible_creator/constants.py Outdated Show resolved Hide resolved
src/ansible_creator/resources/common/execution-environment/execution-environment.yml.j2 Outdated Show resolved Hide resolved
@abhikdps abhikdps requested a review from cidrblock December 9, 2024 18:18
@abhikdps abhikdps closed this Dec 9, 2024
@abhikdps abhikdps reopened this Dec 9, 2024
cidrblock
cidrblock approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@abhikdps abhikdps merged commit 6c79130 into ansible:main Dec 9, 2024
33 checks passed
@abhikdps abhikdps deleted the add_scaffold_ee branch December 9, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

Assignees

@abhikdps abhikdps

Labels
enhancement New feature or request
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhikdps @cidrblock