Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pydoclint via flake 8 #165

Merged
merged 10 commits into from
May 23, 2024
Merged

Conversation

cidrblock
Copy link
Collaborator

Unfortunately it appears the only way to get pydoclint feedback within VsCode is to use it as a flake8 plugin.

  • Move the pydoclint config to .flake8
  • Replace the pydoclint precommit config w/ flake8
  • Add the falke8 extension and cofiguration
  • This is only untill ruff has full doc string support

Additionally, ruff`s docstyle was set to match pydoclint which fixed 4 little issues

(it also appears ruff may implement pydoclint instead of ruff, no decision yet astral-sh/ruff#458 (comment) so I think we're headed in a good direction)

@cidrblock cidrblock requested a review from ssbarnea as a code owner May 23, 2024 15:27
@cidrblock
Copy link
Collaborator Author

Another small non-runtime change, should finalize the dev config in the repo

@cidrblock cidrblock merged commit 6a567b6 into ansible:main May 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant