Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #234

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Add tests #234

merged 2 commits into from
Jul 31, 2024

Conversation

cidrblock
Copy link
Collaborator

  • Add some additional tests
  • Narrow the scope of the type used in treemaker to get rid of some isinstance checks
  • Remove default values from Collection to remove some runtime value checks
  • Remove some merge conflict info found in docstrings

@cidrblock cidrblock requested a review from a team as a code owner July 30, 2024 21:39
@cidrblock cidrblock requested review from audgirka and alisonlhart and removed request for a team July 30, 2024 21:39
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cidrblock cidrblock merged commit 52d4450 into ansible:main Jul 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@shatakshiiii shatakshiiii shatakshiiii approved these changes

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@alisonlhart alisonlhart Awaiting requested review from alisonlhart alisonlhart is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
skip-changelog
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cidrblock @Qalthos @shatakshiiii