Send tar instead of gzipped tar file (required for RHDH plugins) #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audgirka
force-pushed
the
fix/send_tar_file
branch
from
e1a8cfb to
077a4d0
Compare
shatakshiiii
approved these changes
Feb 5, 2025
|
This should have some performance implications. I wonder why we cannot have gzip there. |
cidrblock
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes sending of gzipped tar file.
Now we send only tar files which the ansible scaffolder
plugin from RHDH can extract.
RHDH image does not have gzip available, hence we need this change.
Fixes: https://issues.redhat.com/browse/AAP-38388