-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: refresh dev dependencies #315
Conversation
I'll merge this after CI passes. |
@gotmax23 - this has no reviews. We should only merge dependency changes with at least two approvals. What tests were done to verify the updated dependencies were okay (other than passing CI)? |
This PR only affects the dependencies used by the Python linters. They have zero effect on the docs build. See #258 (comment). I split the linters' dependency update PRs into separate PRs so they could be merged as soon as CI passes. Some repos even have these types of PRs automerge. My reason for pinning the linters in the first place is prevent linter updates from breaking our CI when they e.g. add new rules. As long as the linters still pass, there shouldn't be anything else to check. If you want double reviews for these PRs, I'm happy to oblige, but that feels overkill to me. |
👍 for keeping the linter requirements updated without much procedure. |
This was still merged with zero approvals. Something we should avoid in the future. |
(cherry picked from commit 4ec04d6) Co-authored-by: Github Actions <41898282+github-actions[bot]@users.noreply.github.com>
It wasn't zero approvals. I reviewed the PR. |
Sorry coming back late here and apologies to @gotmax23 - i've been confusing a few things about these dependencies update PRs... I think I've got it figured out now, thanks! |
No description provided.