noxfile: run typing session as part of lint session #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs_triage
`nox -e lint` runs the `static` and `formatters` sessions, but it does not run `nox -e typing` due to an oversight in the initial PR.
|
Force pushed to fix a commit message typo 🙈 |
felixfontein
approved these changes
Sep 5, 2023
oraNod
removed
the
needs_triage
oraNod
approved these changes
Sep 5, 2023
|
This should probably be backported as well, right? |
I think just to stable-2.15 after #342 |
oraNod
added
the
backport-2.15
Indeed. This change is already included in that PR, so I'll remove the |
gotmax23
added
no_backport
|
Thanks for the reviews, @felixfontein and @oraNod! |
gotmax23
added a commit
to gotmax23/ansible-documentation
that referenced
this pull request
Oct 22, 2023
`nox -e lint` runs the `static` and `formatters` sessions, but it does not run `nox -e typing` due to an oversight in the initial PR. (cherry picked from commit 440ae14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nox -e lintruns thestaticandformatterssessions, but it doesnot run
nox -e typingdue to an oversight in the initial PR.