Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horizontal scroll to documentation #422

Merged
merged 1 commit into from
May 11, 2021

Conversation

ZitaNemeckova
Copy link
Member

Fixes https://issues.redhat.com/browse/AAH-599

For https://cloud.redhat.com/ansible/automation-hub/repo/published/ibm/power_ibmi/content/module/ibmi_display_fix
Note: it looks really bad in standalone. In c.r.com you cannot read everything but left nav is visible.

Steps to reproduce:

Before:
Screenshot 2021-05-11 at 8 58 57

After:
Screenshot 2021-05-11 at 9 19 55
Screenshot 2021-05-11 at 9 20 39

@ZitaNemeckova ZitaNemeckova added the backport-4.3 This PR should be backported to stable-4.3 (2.0) label May 11, 2021
@ZitaNemeckova ZitaNemeckova requested a review from himdel May 11, 2021 07:33
@himdel
Copy link
Collaborator

himdel commented May 11, 2021

If the idea is to just make sure the user can scroll to see the whole table, 👍, adding approve.

That said, I think the bug is really elsewhere.. galaxy_ng is the only place that generates a table that's too big to show.
The same content can be seen in the original documentation and on github, neither of which needs wrapping.

EDIT: we should consider not generating tables in the first place, but that's for another discussion

Copy link
Collaborator

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is right if the bug is really considered to be in the UI.
EDIT: it is 👍

(We could also set max-width and rely on wrapping instead of scrollbars, except that may break horribly on phones.)

@newswangerd newswangerd merged commit 430cb0b into ansible:master May 11, 2021
@patchback
Copy link

patchback bot commented May 11, 2021

Backport to stable-4.3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.3/430cb0bcd986aeb97f3b96f58c73d08891cbfa98/pr-422

Backported as #424

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 11, 2021
@newswangerd newswangerd added the backport-4.2 This PR should be backported to stable-4.2 (1.2) label May 11, 2021
@patchback
Copy link

patchback bot commented May 11, 2021

Backport to stable-4.2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.2/430cb0bcd986aeb97f3b96f58c73d08891cbfa98/pr-422

Backported as #425

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 11, 2021
newswangerd pushed a commit that referenced this pull request May 11, 2021
Fixes https://issues.redhat.com/browse/AAH-599

(cherry picked from commit 430cb0b)

Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
newswangerd pushed a commit that referenced this pull request May 11, 2021
Fixes https://issues.redhat.com/browse/AAH-599

(cherry picked from commit 430cb0b)

Co-authored-by: ZitaNemeckova <znemecko@redhat.com>
@himdel himdel added backported-4.2 This PR has been backported to stable-4.2 (1.2) backported-4.3 This PR has been backported to stable-4.3 (2.0) labels May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.3 This PR should be backported to stable-4.3 (2.0) backported-4.2 This PR has been backported to stable-4.2 (1.2) backported-4.3 This PR has been backported to stable-4.3 (2.0)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants