Fix subprocess.run for progressive mode #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyaplis
force-pushed
the
2314/fix-progressive-mode
branch
from
594983a to
699dee2
Compare
ssbarnea
approved these changes
Aug 23, 2022
ssbarnea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2314
Several issues I've noticed with recently introduced
subprocess.runfor git commands in progressive mode:git rev-parse HEAD^1returns a newline, so have to be stripped, otherwise errorgit worktree add -f worktree_dirusesshell=True. It expects a string so it fails with a list of arguments as reported in issue Progressive mode is broken as of 6.5.0 #2314 )git checkout revisionusesshell=True. Same as abovegit worktree add -f worktree_dirusescheck=True. It fails when the directory already exists. So each subsequentansible-lintrun will fail