Skip to content

Commit

Permalink
relrod PR review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
cidrblock committed Dec 1, 2021
1 parent fbfe8cb commit 01640a9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
4 changes: 1 addition & 3 deletions src/ansible_navigator/actions/_actions.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,7 @@ def run_interactive(package: str, action: str, *args: Any, **_kwargs: Any) -> An
if hasattr(action_cls(app.args), "run"):
return action_cls(app.args).run(app=app, interaction=interaction)
logger.error("Subcommand '%s' does not support mode interactive", action)
if hasattr(action_cls(app.args), "no_interactive_mode"):
return action_cls(app.args).no_interactive_mode(app=app, interaction=interaction)
return None
return action_cls(app.args).no_interactive_mode(app=app, interaction=interaction)


def run_interactive_factory(package: str) -> Callable:
Expand Down
2 changes: 1 addition & 1 deletion src/ansible_navigator/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def app(self) -> AppPublic:

def no_interactive_mode(self, interaction: Interaction, app: AppPublic) -> None:
# pylint: disable=unused-argument
"""Warm the user interactive mode is not supported"""
"""Warn the user interactive mode is not supported"""
warning = warning_notification(
messages=[
f"The '{self._name}' subcommand is not available while using interactive mode.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class Internals(SimpleNamespace):
epilog=(
"Note: During development, it may become necessary to interact"
" directly with the execution environment to review and confirm"
" it's build and behavior. All navigator settings will be applied"
" its build and behavior. All navigator settings will be applied"
" when starting the execution environment."
),
),
Expand Down Expand Up @@ -271,7 +271,6 @@ class Internals(SimpleNamespace):
settings_file_path_override="exec.shell",
short_description=(
"Specify the exec command should be run in a shell."
" ('/bin/bash -c \"{exec_command}\"')"
),
subcommands=["exec"],
value=EntryValue(default=True),
Expand Down

0 comments on commit 01640a9

Please sign in to comment.