ansible-navigator failed when first meta task is skipped

[abikouo]

ISSUE TYPE

• Bug Report

SUMMARY

ANSIBLE-NAVIGATOR VERSION

ansible-navigator 1.1.0a1

CONFIGURATION

STEPS TO REPRODUCE

ansible-navigator run ./test_inventory.yml -m stdout  -v -i ./inventory.ini

test_inventory.yml

- hosts: all
  gather_facts: no
  
  tasks:
    - name: End play if remote host
      meta: end_host
      when: host_type != "container"

inventory.ini

[all]
localhost              ansible_connection=local   host_type="container"

EXPECTED RESULTS

navigator should execute the playbook successfully

ACTUAL RESULTS

ansible-navigator fails to execute playbook

TASK [End play if remote host] *************************************************
skipping: [localhost] => {"msg": "end_host conditional evaluated to false, continuing execution for localhost", "skip_reason": "end_host conditional evaluated to False, continuing execution for localhost"}
Traceback (most recent call last):
  File "/home/aubin/work/env/py38.0/bin/ansible-navigator", line 8, in <module>
    sys.exit(main())
  File "/home/aubin/work/env/py38.0/lib/python3.8/site-packages/ansible_navigator/cli.py", line 141, in main
    return_code = run(args)
  File "/home/aubin/work/env/py38.0/lib/python3.8/site-packages/ansible_navigator/cli.py", line 79, in run
    return_code = run_action_stdout(args.app.replace("-", "_"), args)
  File "/home/aubin/work/env/py38.0/lib/python3.8/site-packages/ansible_navigator/actions/_actions.py", line 109, in run_stdout
    return action_cls(args).run_stdout()
  File "/home/aubin/work/env/py38.0/lib/python3.8/site-packages/ansible_navigator/actions/run.py", line 249, in run_stdout
    self._dequeue()
  File "/home/aubin/work/env/py38.0/lib/python3.8/site-packages/ansible_navigator/actions/run.py", line 612, in _dequeue
    self._handle_message(message)
  File "/home/aubin/work/env/py38.0/lib/python3.8/site-packages/ansible_navigator/actions/run.py", line 664, in _handle_message
    task["__duration"] = human_time(seconds=round(task["duration"], 2))
TypeError: type NoneType doesn't define __round__ method

[cidrblock]

hello @abikouo

thanks for the recreate here, I get the same result, it seems the entry for the task has a duration of None when we get it

0.0s _handle_message: 
      task={'__changed': False, '__result': 'SKIPPED', 'duration': None, 'end': None, 'event_loop': None, 'host': 'localhost', 'play': 'all', 'play_pattern': 'all', 'play_uuid': 'fa235c58-3d26-fd0c-f7ed-000000000006', 'playbook': '/home/bthornto/github/ansible-navigator/site.yaml', ...}

Which can't be rounded :)

This should be an easy fix, something like this in action/run/handle_message should work:

 if isinstance(task["duration"], (int, float)):
                        task["__duration"] = human_time(seconds=round(task["duration"], 2))
                    else:
                        msg = f"Task duration for \'{task['task']}\' was type {type(task['duration'])}, set to 0"
                        self._logger.debug(msg)
                        task["__duration"] = 0

which would result in a log message of

211029115352.446 DEBUG 'ansible_navigator.actions.run_playbook._handle_message' Task duration for 'End play if remote host' was type <class 'NoneType'>, set to 0

thanks again for this & the repro!

-Brad