Centralize json dump and dumps #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cidrblock
force-pushed
the
centralize_json
branch
from
40f1709
to
8d7646b
Compare
for more information, see https://pre-commit.ci
relrod
approved these changes
Feb 24, 2022
cidrblock
added a commit
to cidrblock/ansible-navigator
that referenced
this pull request
Feb 25, 2022
cidrblock
added a commit
to cidrblock/ansible-navigator
that referenced
this pull request
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralizes the json dumping into one location, to prevent issues like the below and will allow for a different encoder in one place.
Fixes #1003
(yaml can be moved into this file as well to centralize all serializers)