Add settings --schema support
#1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshrn
reviewed
Mar 17, 2022
ganeshrn
reviewed
Mar 17, 2022
ganeshrn
reviewed
Mar 17, 2022
src/ansible_navigator/configuration_subsystem/navigator_configuration.py
Outdated
Show resolved
Hide resolved
cidrblock
changed the title
settings --json-schema supportsettings --schema support
ssbarnea
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a JSON schema for the ansible-navigator settings file.
(it defaults to
json, which is the only choice today)This is not 100% settings driven, the types and fields really need to wait until the settings entries are fully typed and annotation can be used to derive JSON types, but it is a start.
A future PR will use the json schema to validate the settings file the user has provided.