Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update exec action to return with correct exit code #1330

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Update exec action to return with correct exit code #1330

merged 2 commits into from
Nov 9, 2022

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii commented Nov 2, 2022 •
edited
Loading

Resolves: #1215

@shatakshiiii shatakshiiii added bug Researched, reproducible, committed to fix AAP Ansible automation platform labels Nov 2, 2022
ssbarnea
ssbarnea approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but wait for @cidrblock to approve this one as I am not sure if there are other undesired side effects that I may miss.

@shatakshiiii shatakshiiii merged commit 30438df into ansible:main Nov 9, 2022
@shatakshiiii shatakshiiii deleted the exec_action branch November 9, 2022 07:04
@shatakshiiii shatakshiiii self-assigned this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@cidrblock cidrblock Awaiting requested review from cidrblock

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn is a code owner automatically assigned from ansible/devtools

@trishnaguha trishnaguha Awaiting requested review from trishnaguha trishnaguha is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees

@shatakshiiii shatakshiiii

Labels
AAP Ansible automation platform bug Researched, reproducible, committed to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exec action doesn't return the original exit code
2 participants
@shatakshiiii @ssbarnea