Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging dependencies #1554

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fix logging dependencies #1554

merged 2 commits into from
Jun 14, 2023

Conversation

shatakshiiii
Copy link
Contributor

Fixes: #1553

@shatakshiiii shatakshiiii added the bug Researched, reproducible, committed to fix label Jun 14, 2023
cidrblock
cidrblock approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

cidrblock
cidrblock approved these changes Jun 14, 2023
View reviewed changes
src/ansible_navigator/cli.py Show resolved Hide resolved
@shatakshiiii shatakshiiii merged commit b2849c0 into ansible:main Jun 14, 2023
@shatakshiiii shatakshiiii deleted the fix_logging_deps branch June 14, 2023 16:24
@shatakshiiii shatakshiiii self-assigned this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16 Ruchip16 is a code owner automatically assigned from ansible/devtools

Assignees

@shatakshiiii shatakshiiii

Labels
bug Researched, reproducible, committed to fix
Projects
None yet
Milestone
No milestone
2 participants
@shatakshiiii @cidrblock