Guard against using unittest ecosystem within pylint #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
added
enhancement
cidrblock
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Approving to avoid mixing the 2.
But.......... Some clean up help here would be appreciated, if anyone wants to pick some off.
Also- Let's not push too hard in the future if another comes through until these are remediated and there are repeatable examples in the code base that we can point to.
webknjaz
force-pushed
the
maintenance/pytest-over-unittest
branch
from
41fd9fb
to
d295c85
Compare
This patch implements recommendations to use `pytest`-native fixtures instead of importing `unittest`-world helper untilities directly using a built-in `pylint` rule `preferred-module`.
webknjaz
force-pushed
the
maintenance/pytest-over-unittest
branch
from
d295c85
to
adac1a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements recommendations to use
pytest-native fixturesinstead of importing
unittest-world helper untilities directly usinga built-in
pylintrulepreferred-module.