Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unicode character output for json and yaml in TUI #944

Merged
merged 6 commits into from
Feb 15, 2022

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Feb 13, 2022

Fixes #256

  • Update the yaml dumper to allow_unicode
  • Update the json dumps to ensure ascii is false
  • No tests from :welcome included, as it didn't seem necessary in this case

Rather than over complicate the current integration tests for run, a new suite of tests were made for run, specifically for unicode output in all scenarios.

Copy link
Member

@relrod relrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make emoji work too? 💯 🌮

@cidrblock
Copy link
Collaborator Author

no.... is that a thing?

image

@cidrblock cidrblock merged commit 4e14c89 into ansible:main Feb 15, 2022
@cidrblock cidrblock added the enhancement New feature or request label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigator should preserve unicode task output
2 participants