Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore original signal handlers in finished_callback #1402

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

bbatliner-ocient
Copy link

The change in #862 added signal handlers for SIGINT and SIGTERM that may replace any existing SIGINT or SIGTERM handlers set by the process. Those existing handlers are not restored when the ansible_runner.run call finishes.

The solution here uses the finished_callback to restore the handlers. We're relying on the finished_callback actually getting called, which I'm not sure is a real guarantee. I'd be open to a solution that uses context managers or try-finally if we can figure out the right refactoring / where to put the try-finally semantics.

We are solving this problem today by using an ExitStack and a custom cancel_callback (that basically implements the same SIGINT/SIGTERM cancellation behavior as #862) that guarantees to restore the original handlers after the call completes.


TODOS

  • I wasn't sure where or how to write a test for the end-to-end signal restoring functionality. I found unit tests in test/unit/test_interface.py and test/unit/utils/test_utils.py that seem related, but wouldn't test the full "set and reset" behavior implemented here. Any pointers appreciated.
  • There is a TODO noted in the code that saving and restoring signal handlers set from outside Python, i.e. a C extension, is not possible. signal.getsignal returns None for these handlers. How does ansible-runner want to handle such a case? Options seem to be: (1) silently fail to restore (same behavior as today), (2) raise an exception (breaking change), or (3) allow the behavior to be configured.

@bbatliner-ocient bbatliner-ocient requested a review from a team as a code owner November 8, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant