Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_group: use default values for object returned from aws to prevent TypeError … #31531

Closed
wants to merge 1 commit into from
Closed

ec2_group: use default values for object returned from aws to prevent TypeError … #31531

wants to merge 1 commit into from

Conversation

s-hertel
Copy link
Contributor

… (#31455)

SUMMARY

Merged to devel in #31455.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/ec2_group.py

ANSIBLE VERSION
ansible 2.4.0.0 (2.4_ec2_group_nonetype_iterable_bug 6df6f79bbd) last updated 2017/10/10 10:16:52 (GMT -400)
  config file = /Users/shertel/Workspace/ansible/ansible.cfg
  configured module search path = [u'/Users/shertel/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/shertel/Workspace/ansible/lib/ansible
  executable location = /Users/shertel/Workspace/ansible/bin/ansible
  python version = 2.7.10 (default, Jul 30 2016, 19:40:32) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)]

@arnonki @s-hertel
Use default values for object returned from aws to prevent TypeError (a…
6df6f79 
…nsible#31455)

* Use default values for object returned from aws to prevent TypeError
NoneType exception fixes ansible#31454
@ansibot
Copy link
Contributor

ansibot commented Oct 10, 2017

cc @adq
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 aws backport This PR does not target the devel branch. bugfix_pull_request cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 10, 2017
ryansb
ryansb approved these changes Oct 10, 2017
View reviewed changes
Copy link
Contributor

@ryansb ryansb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-hertel
Copy link
Contributor Author

Merged in 0e01684.

@s-hertel s-hertel closed this Oct 10, 2017
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Oct 13, 2017
@pyup-bot pyup-bot mentioned this pull request Jan 1, 2018
Closed
This was referenced Jan 31, 2018
Closed
Closed
Closed
Closed
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daxlab daxlab daxlab approved these changes

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@s-hertel @ansibot @ryansb @daxlab @arnonki