Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client_id and client_secret fields to Insights credential #71

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

fosterseth
Copy link
Member

@fosterseth fosterseth commented Dec 13, 2024

Adds client_id and client_secret fields to the existing insights credential so that users can authenticate with a service account instead of basic auth

so users should either use username/password, or client_id/client_secret

if client_id is set, then authentication method is set to "service_account" automatically

@fosterseth fosterseth force-pushed the insights_service_account branch from 4cce8e2 to c9b12f3 Compare December 13, 2024 18:40
Signed-off-by: Seth Foster <fosterbseth@gmail.com>
Signed-off-by: Seth Foster <fosterbseth@gmail.com>
Signed-off-by: Seth Foster <fosterbseth@gmail.com>
@fosterseth fosterseth force-pushed the insights_service_account branch 2 times, most recently from 84d9ffa to 7e80022 Compare January 9, 2025 14:31
@fosterseth fosterseth changed the title [WIP] Add client_id and client_secret fields to Insights cred Add client_id and client_secret fields to Insights cred Jan 9, 2025
@fosterseth fosterseth changed the title Add client_id and client_secret fields to Insights cred Add client_id and client_secret fields to Insights credential Jan 9, 2025
Signed-off-by: Seth Foster <fosterbseth@gmail.com>
@chrismeyersfsu
Copy link
Member

chrismeyersfsu commented Jan 9, 2025

Looks like this will work if your plan is to consume it in the project update, but I think you will need to define a custom_injectors for this to work for the inventory update case.

edit: Actually, maybe not. But something over in inventory plugin land will need to be updated to produce

plugin: redhat.insights.insights

authentication: basic
user: "insights username"
password: "insights password"

OR

plugin: redhat.insights.insights
authentication: service_account
client_id: "service account client-id"
client_secret: "service account client-secret"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants