Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing write location of ssh_key-data-cert.pub #12122

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

john-westcott-iv
Copy link
Member

SUMMARY

Fixing regression from #12083 where the ssh_key-data-cert.pub files were not properly being written into the artificats/ folder.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • API
AWX VERSION
awx: 20.1.1.dev103+ga9639c4831
ADDITIONAL INFORMATION

@AlanCoding
Copy link
Member

os.mkdir(base_path, 0o700)

Does this not need to be os.makedirs? Or a loop or something..

@john-westcott-iv
Copy link
Member Author

os.mkdir(base_path, 0o700)

Does this not need to be os.makedirs? Or a loop or something..

I think the previous assumption was that "something else" was creating the directories. But I like this idea, especially with a sub_dir option that can be multiple directories.

@InnocentK InnocentK self-assigned this Apr 28, 2022
Copy link
Contributor

@InnocentK InnocentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my testing this seems to have resolved the issue. Great work!

@cypress
Copy link

cypress bot commented Apr 28, 2022



Test summary

638 0 821 0Flakiness 2


Run details

Project AWX - Functional
Status Passed
Commit a020c48
Started Apr 28, 2022 8:13 PM
Ended Apr 28, 2022 10:15 PM
Duration 02:04 💡
OS Linux Debian - 11.3
Browser Chrome 99

View run in Cypress Dashboard ➡️


Flakiness

workflow-approvals/workflow-approvals-operations.spec.js Flakiness
1 Workflow approval list > can cancel a single workflow
workflows/workflow-visualizer/workflow-viz-wfjt-node-prompt-and-survey.spec.js Flakiness
1 Workflow node within a workflow > can prompt and survey against a workflow node with empty visualizer and save

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@john-westcott-iv john-westcott-iv merged commit 13f7166 into ansible:devel Apr 29, 2022
@Tioborto Tioborto mentioned this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants