-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing write location of ssh_key-data-cert.pub #12122
Fixing write location of ssh_key-data-cert.pub #12122
Conversation
a9639c4
to
16e2bfa
Compare
Line 127 in 16e2bfa
Does this not need to be |
I think the previous assumption was that "something else" was creating the directories. But I like this idea, especially with a sub_dir option that can be multiple directories. |
16e2bfa
to
a020c48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my testing this seems to have resolved the issue. Great work!
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
SUMMARY
Fixing regression from #12083 where the ssh_key-data-cert.pub files were not properly being written into the artificats/ folder.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION