-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more context to subscription details and rearrange the order of some of the fields #12649
Added more context to subscription details and rearrange the order of some of the fields #12649
Conversation
I'm curious what the thinking is on using static help text here when we use Popovers in all other Details. (There is certainly an accessibility argument for using static text everywhere.) |
@keithjgrant - Yea I'll defer to @ffirg but I think the idea is to put something right in the users face. If we put this in a tooltip/popover it might be too subtle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Is there an issue tracking this work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! (ignore the failing tests above--those are unrelated to these changes)
… some of the fields (#12649) * Adds more context to subscription details and rearranges some of the fields * Fixes broken unit test after updating subscription details
SUMMARY
Adds static help text to subscription details depending on status. Moved a number of compliance related fields up to the beginning of the details view. See the original issue for more details.
ISSUE TYPE
COMPONENT NAME