Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more context to subscription details and rearrange the order of some of the fields #12649

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

mabashian
Copy link
Member

SUMMARY

Adds static help text to subscription details depending on status. Moved a number of compliance related fields up to the beginning of the details view. See the original issue for more details.

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • UI

@keithjgrant
Copy link
Member

I'm curious what the thinking is on using static help text here when we use Popovers in all other Details. (There is certainly an accessibility argument for using static text everywhere.) <Detail> has a helpText prop that uses a Popover... I'm wondering if we should use that

@mabashian
Copy link
Member Author

@keithjgrant - Yea I'll defer to @ffirg but I think the idea is to put something right in the users face. If we put this in a tooltip/popover it might be too subtle.

Copy link
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@AlexSCorey
Copy link
Member

Is there an issue tracking this work?

@cypress
Copy link

cypress bot commented Aug 18, 2022



Test summary

647 9 769 0Flakiness 3


Run details

Project AWX - Functional
Status Failed
Commit 31fb77d
Started Aug 18, 2022 8:27 PM
Ended Aug 19, 2022 12:07 AM
Duration 39:27 💡
OS Linux Debian - 11.3
Browser Chrome 100

View run in Cypress Dashboard ➡️


Failures

credentials/credential-crud.cy.js Failed
1 Create and delete Credentials > Can create, edit, and delete Google Compute Engine credential using required fields
job-templates/job-template-tabs.cy.js Failed
1 Job Templates Tab- Schedules > Can add prompted fields and survey to a scheduled JT
2 Job Templates Tab- Schedules > Can add prompted fields and survey to a scheduled JT
schedules/schedule-crud.cy.js Failed
1 Create a schedule > can create a schedule from the schedules tab and verify that the date picker functions properly
2 Add schedule form > can create a schedule with a weekly frequency
3 Edit schedule form > can edit a schedule to use a different kind of frequency
4 Edit schedule form > can cancel editing a form without changes to the schedule
workflow-approvals/workflow-approvals-operations.cy.js Failed
1 Workflow approvals - Details > can cancel a workflow
management-jobs/management-job-operations.cy.js Failed
1 Management jobs > can add a schedule to launch a management job

Flakiness

inventories/inventory-host-operations.cy.js Flakiness
1 Inventory Host list- Operations > can sort hosts by name after performing advanced search
user-journeys/auditor-journey.cy.js Flakiness
1 Inventories > cannot Run command, add or disassociate related groups
user-journeys/normal-user-journey.cy.js Flakiness
1 Activity stream > a normal user should be able to see only allowed events

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@InnocentK InnocentK self-assigned this Aug 19, 2022
Copy link
Contributor

@InnocentK InnocentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (ignore the failing tests above--those are unrelated to these changes)

@InnocentK InnocentK merged commit bf9f1b1 into ansible:devel Aug 19, 2022
AlexSCorey pushed a commit that referenced this pull request Oct 11, 2022
… some of the fields (#12649)

* Adds more context to subscription details and rearranges some of the fields

* Fixes broken unit test after updating subscription details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants