Fix sanity check to use the relevant active connection #12769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This was a bug I introduced and is tracked in #12740
When doing a control-with-reply to determine the status of a job, we should unambiguously use a new connection. There is no question about that, and it was an oversight that I missed this particular import of
pg_bus_conn. If we run out of connections, the exception will be caught andcancel_flagshould still get flipped, which is what we want.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
This hopefully replaces #12741, I still need to run tests quickly.