Add link to service-index URL #14984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamack
approved these changes
Mar 13, 2024
|
I've struggled with the name too. The API basically indexes the content of the service, which is why I landed on service-index. I would almost be tempted to just keep these apis internal for the gateway and to not list them anywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
A goal of the AWX API is to be navigable, so in ansible/django-ansible-base#188 DAB added a "splash" page for the resource registry URLs.
This links the AWX root navigation to that. I selfishly want this because we have crawler tests that keep finding issues with new URLs, and I believe it is missing issues with the resource registry URLs because it is unexpectedly not navigable by links. These problems are shared by the new RBAC endpoints.
Connect #14951
Tested manually that it works. We have to use a special thing for doing the
reverse.Also, I hate the name of this, because it doesn't help understand what it does. @newswangerd if you have any other suggestions for the dictionary key (as opposed to "service_index"), we could change that.
ISSUE TYPE
COMPONENT NAME