Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen up body check on template #14995

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Loosen up body check on template #14995

merged 1 commit into from
Mar 29, 2024

Conversation

dmzoneill
Copy link
Member

SUMMARY

Loosen up body check on template.
Allow 1 line

#14985
#13983

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@@ -498,7 +498,7 @@ def build_notification_message(self, nt, status):
# Body should have at least 2 CRLF, some clients will interpret
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the description need to be updated too?

@github-actions github-actions bot added the component:awx_collection issues related to the collection for controlling AWX label Mar 25, 2024
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks fine to me. I would add onto Hao's comment so lets make sure we don't need to update that.

update to the test passed successfully, I would update the issue once this is merged and see if the users are still seeing issues/have them test this.

@dmzoneill dmzoneill merged commit bb323c5 into devel Mar 29, 2024
21 checks passed
@dmzoneill dmzoneill deleted the dmzoneill-14985 branch March 29, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api component:awx_collection issues related to the collection for controlling AWX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants