Remove uneeded drf_reverse overwrite #15078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `drf_reverse()` was introduced here ansible@1a75b18 * There is a comment about monkey patching. I can't find the monkey patch it is referencing. * AWX `drf_reverse()` is a copy paste of this https://github.com/encode/django-rest-framework/blob/master/rest_framework/reverse.py#L32 * The only difference is DRF's version calls `preserve_builtin_query_params()` * `preserve_builtin_query_params()` only does something if `api_settings.URL_FORMAT_OVERRIDE` is defined. * We don't use `REST_FRAMEWORK.URL_FORMAT_OVERRIDE`
|
Do named URLs still work with this change? That's what this was probably added to support. |
|
Tested with https://localhost:8043/api/v2/job_templates/Demo%20Job%20Template++Default/ and still seems to work alright. |
AlanCoding
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
drf_reverse()was introduced here 1a75b18drf_reverse()is a copy paste of this https://github.com/encode/django-rest-framework/blob/master/rest_framework/reverse.py#L32preserve_builtin_query_params()*preserve_builtin_query_params()only does something ifapi_settings.URL_FORMAT_OVERRIDEis defined. * We don't useREST_FRAMEWORK.URL_FORMAT_OVERRIDEISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION