Add ability to set SameSite policy for userLoggedIn cookie #15100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealHaoLiu
approved these changes
Apr 10, 2024
chrismeyersfsu
approved these changes
Apr 10, 2024
|
@chrismeyersfsu @TheRealHaoLiu Is the api-test workflow buggy? I run the same tests locally and it passes without issue. |
TheRealHaoLiu
force-pushed
the
user-samesite-policy
branch
from
f78b38f
to
6563128
Compare
|
rebased and kicked off the test, we had a couple CI failure last week cause by django ansible base |
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
…5100) * Add ability to set SameSite policy for userLoggedIn cookie * reformat line for linter
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
…5100) * Add ability to set SameSite policy for userLoggedIn cookie * reformat line for linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add the ability to set the SameSite policy for userLoggedIn cookie. By default this is blank today. This change sets the default to Lax which when not set most modern browser interrupt it as Lax. This adds a new variable that can be set via extra_settings to override this and add the ability to set the SameSite policy to Strict.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION