Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports previously approved corrections. #15121

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Conversation

tvo318
Copy link
Member

@tvo318 tvo318 commented Apr 19, 2024

SUMMARY

This PR picks up all the fixes from the following product-docs PRs:

  • 4.4: 2005 (smart inv: variables no longer modifiable)
  • 4.x: 2009 (JT extra vars)
  • 4.4, 4.3: 2011 (LDAP local user info and SAML social auth refs)

This PR doesn't need a formal review since the changes have been previously approved via their original PRs.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Docs
AWX VERSION

latest

@tvo318 tvo318 requested a review from oraNod April 19, 2024 21:21
Comment on lines 100 to 101
Variables on Host and Group are not changeable even as the local system admin user.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Variables on Host and Group are not changeable even as the local system admin user.
Variables on Host and Group are not changeable even as the local system admin user.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to insert an empty line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oraNod - It doesn't affect anything. I can remove it per your suggestion.

@tvo318 tvo318 requested a review from oraNod April 22, 2024 15:19
Copy link
Collaborator

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvo318 tvo318 merged commit 814ceb0 into ansible:devel Apr 22, 2024
21 checks passed
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
* Backports previously approved corrections.

* Deleted a blank line in inventories line 100
@tvo318 tvo318 deleted the backports branch September 27, 2024 17:22
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
* Backports previously approved corrections.

* Deleted a blank line in inventories line 100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants