Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention in the docs that you can skip make docker-compose-build #15149

Merged
merged 1 commit into from
May 22, 2024

Conversation

AlexPykavy
Copy link
Contributor

@AlexPykavy AlexPykavy commented Apr 26, 2024

SUMMARY

I've decided to improve the docs a bit as discussed in the #15082.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Tools
AWX VERSION
awx: 24.3.1.dev9+g4123bc482e.d20240426

@AlexPykavy
Copy link
Contributor Author

By the way, make VERSION didn't work for me out of the box. I had to:

  • VENV_BASE=./venv make virtualenv. Is it fine to override the VENV_BASE to be in the repo?
  • . ./venv/awx/bin/activate
  • make VERSION

Is it documented anywhere?

@jessicamack jessicamack enabled auto-merge (squash) May 15, 2024 19:14
@jessicamack
Copy link
Member

Hello @AlexPykavy, thank you for your contribution. We don't have the VENV specifics documented, but setup tools is required for make VERSION to work. What failure did you see when you ran make VERSION? Would you mind opening a separate issue for that error?

@TheRealHaoLiu
Copy link
Member

rebase to pickup CI fixes

Signed-off-by: Alexander Pykavy <aleksandrpykavyj@gmail.com>
@TheRealHaoLiu
Copy link
Member

auto merge enabled, this PR will merge automatically after CI passes

@jessicamack jessicamack merged commit c3d9aa5 into ansible:devel May 22, 2024
20 checks passed
@AlexPykavy
Copy link
Contributor Author

@jessicamack , sure. I'll open one.

djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
…sible#15149)

Signed-off-by: Alexander Pykavy <aleksandrpykavyj@gmail.com>
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
…sible#15149)

Signed-off-by: Alexander Pykavy <aleksandrpykavyj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants