Do some aesthetic adjustments to role presentation fields #15153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
force-pushed
the
adjust_names
branch
from
5dc2fd9
to
ad1625b
Compare
AlanCoding
commented
Apr 29, 2024
| 'special': '{cls.__name__} {action}', | ||
| } | ||
| # This has been moved to data migration code | ||
| ANSIBLE_BASE_ROLE_PRECREATE = {} |
There was a problem hiding this comment.
This was a big goof. Since I had put up ansible/django-ansible-base#296 I confused myself about the contract with DAB. This was unexpectedly creating the managed role definitions in the post_migrate hook, in addition to AWX logic I added that did the same thing. Had it been removed in DAB (i.e. 296 was merged) that might have worked, but the path forward isn't super clear for that and I have cold feet on it.
In other words, we had duplicate role definitions which was causing unexpected names to be found.
jbradberry
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Firstly this is adding a test to assure we have Capital Letters.
We also want to be sure that anything that we ship has a description.
Most notably, this fixes an issues where an auto-created RoleDefinition would have
created_byset, and we don't want that, because it shouldn't be attributed to such an (ordinary) user.ISSUE TYPE
COMPONENT NAME