Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make kombu DNS failures louder in the logs #4857

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

ryanpetrello
Copy link
Contributor

@ryanpetrello ryanpetrello commented Sep 30, 2019

kombu has a behavior in its Connection.ensure_connection code where it quietly backs off and retries certain types of connection issues (forever) - DNS resolution OSErrors are one of those. This makes these events much more verbose in the AWX logs to aid in debugging

Copy link
Contributor

@jbradberry jbradberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version seems like the right thing.

Copy link
Contributor

@jbradberry jbradberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗿

@ryanpetrello
Copy link
Contributor Author

You can test this by editing BROKER_URL by hand and putting in a bad hostname:

image

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@ryanpetrello
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants