make kombu DNS failures louder in the logs #4857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanpetrello
force-pushed
the
kombu-dns
branch
from
ecb9682
to
2009ae1
Compare
jbradberry
approved these changes
Sep 30, 2019
ryanpetrello
force-pushed
the
kombu-dns
branch
from
2009ae1
to
b80eafe
Compare
ghjm
approved these changes
Sep 30, 2019
|
You can test this by editing
|
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kombu has a behavior in its
Connection.ensure_connectioncode where it quietly backs off and retries certain types of connection issues (forever) - DNS resolutionOSErrors are one of those. This makes these events much more verbose in the AWX logs to aid in debugging