Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

Keep rpm db #277

Merged
merged 10 commits into from
Jan 12, 2023
Merged

Keep rpm db #277

merged 10 commits into from
Jan 12, 2023

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Jan 12, 2023 •
edited
Loading

ansible-navigator runs rpm -qa to catalog the installed system packages.

We'll keep the rpm db.

https://github.com/ansible/ansible-navigator/blob/e915bcf08aaec4cbbd59c76587c4d53d3346b16a/share/ansible_navigator/utils/image_introspect.py#L347

Additionally add a check for ansible-runner's presence, related #275

@cidrblock cidrblock added the bug Something isn't working label Jan 12, 2023
@cidrblock cidrblock requested a review from a team as a code owner January 12, 2023 14:14
ssbarnea
ssbarnea suggested changes Jan 12, 2023
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a change that runs rpm -qa when validating the container, so we do not accidentally remove it later.

@cidrblock cidrblock mentioned this pull request Jan 12, 2023
Merged
@ssbarnea ssbarnea merged commit 8c45b92 into ansible:main Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cidrblock @ssbarnea