Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker-buildx): use correct buildx variable for cross-compilation #158

Merged
merged 2 commits into from
Jan 7, 2024
Merged

fix(docker-buildx): use correct buildx variable for cross-compilation #158

merged 2 commits into from
Jan 7, 2024

Commits on Jan 2, 2024

  1. fix(docker-buildx): use correct buidx variable for cross-compilation 

    `BUILDPLATFORM` is the architecture for the machine building the image. this var is not for cross-compilation.

`TARGETPLATFORM` is the correct variable to use for cross-compilation.
    @jon-nfc
    jon-nfc committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    3911fba View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. refactor: remove actions that do the same things as if they never exi… 

    …sted in the first place

The editing of the dockerfile is not required as specifying the platform in the `FROM` statement is already done by default.

These lines of code are useless
    @jon-nfc
    jon-nfc committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    69e889b View commit details
    Browse the repository at this point in the history