Adds pid_mode feature to docker driver #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me! |
decentral1se
reviewed
Nov 1, 2018
decentral1se
approved these changes
Nov 1, 2018
This was referenced Jan 28, 2019
|
Can you rebase @angelbarrera92? Added to agenda in ansible/community#427. Please join if you have time! |
|
@lwm i will rebase asap ;) |
Signed-off-by: Angel Barrera <angel.barrera@intelygenz.com>
themr0c
approved these changes
Jan 29, 2019
|
Could you re-launch the tests of this change? I think it failed by timeout:
Thanks! |
|
Restarted @angelbarrera92! Thanks for your patience 👍 |
|
Hey @angelbarrera92, it looks like there are some conflicts with the current |
|
Resolved! |
decentral1se
approved these changes
Feb 26, 2019
|
🚀 |
ssbarnea
pushed a commit
to ssbarnea/molecule
that referenced
this pull request
Feb 27, 2019
Signed-off-by: Angel Barrera <angel.barrera@intelygenz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1534
Adds
pid_modeconfiguration parameter listen in docker ansible moduleThanks!