Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #1556 VERR_ACCESS_DENIED #1600

Merged
merged 1 commit into from
Oct 12, 2019
Merged

Fixing #1556 VERR_ACCESS_DENIED #1600

merged 1 commit into from
Oct 12, 2019

Conversation

jonashackt
Copy link
Contributor

@jonashackt jonashackt commented Nov 23, 2018

This should fix #1556 "vagrant driver writes vagrant-console-log to installation dir instead of $TMPDIR".

I just added 'modifyvm', :id, '--uartmode1', 'disconnected' to the default Vagrantfile of Molecule, as this seems to fix the issue. See also https://github.com/jonashackt/molecule-ansible-docker-vagrant/blob/master/docker/molecule/vagrant-ubuntu/molecule.yml

PR Type

  • Bugfix Pull Request

This should fix ansible#1556 "vagrant driver writes vagrant-console-log to installation dir instead of $TMPDIR". I just added `'modifyvm', :id, '--uartmode1', 'disconnected'` to the default Vagrantfile of Molecule.

Signed-off-by: Jonas Hecht <jonas.hecht@codecentric.de>
@decentral1se
Copy link
Contributor

Any ideas how we can test this @jonashackt?

@jonashackt
Copy link
Contributor Author

@lwm not really, as TravisCI & CircleCI don't support Vagrant. But maybe AppVeyor would be a choice, I created an example project here: https://github.com/jonashackt/vagrant-ansible-on-appveyor As of what I got to know, this should work. But sadly - also the AppVeyor support doesn't know, why - it's not working...

@jonashackt
Copy link
Contributor Author

But how does the Vagrant testing work for the current implementation anyway @lwm ?

@decentral1se
Copy link
Contributor

Heyo. I don't know how it's been doing (if at all) for Vagrant here. Vagrant functionality is definitely a solid and well desired feature for this tool, so hopefully there is something in place which you can extend. If not, it would be nice to know how difficult it is to do (and perhaps create a ticket to track that also).

@decentral1se decentral1se added this to the v.2.21 milestone Jan 31, 2019
@decentral1se decentral1se removed this from the v.2.21 milestone Feb 27, 2019
@decentral1se
Copy link
Contributor

Anyone using Vagrant can please provide some guidance here?

I don't feel confident to merge this at all.

@t2d
Copy link
Contributor

t2d commented May 25, 2019

I need to do this all the time manually to make the official Ubuntu vagrant images run.

@jonashackt
Copy link
Contributor Author

jonashackt commented May 28, 2019

I already tried to automatically test a Vagrant environment, but failed on TravisCI and CircleCI, since they are both blocking a VirtualBox & Vagrant installation. However I got quite far on AppVeyor - there, you can install VirtualBox and Vagrant like a charm, only thing that's left there is the Vt-x CPU support of the standard machines there - this feature needs payment.

BUT: AFAIK there is a possibilty to request such a machine with VT-x enabled for OpenSource projects. We could try to request such a machine for Molecule and setup a exhaustive Vagrant test setup?!

@decentral1se
Copy link
Contributor

@jonashackt if you have any free cycles to pursue this, I would gladly support you here. I think long term, we're looking at breaking out these drivers into their own plugin / test environments but for now, it would be great to make some progress on testing this right now.

@ssbarnea ssbarnea self-requested a review June 14, 2019 08:50
@ssbarnea
Copy link
Member

Is there a way to run ansible tests only for Vagrant? I have two hosts with vagrant installed and I could manually test it. Hopefully the modified code is covered by some of the tests.

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to make this pass when testing with a vagrant enabled machine:
Rebase it first and retry with:
MOLECULE_DEBUG=1 pytest "test/functional/test_command.py::test_command_check[driver/vagrant-vagrant-default]"

@ssbarnea ssbarnea self-requested a review October 12, 2019 10:04
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually, worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vagrant driver writes vagrant-console-log to installation dir instead of $TMPDIR
5 participants