Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix the CI: remove comment that Tox cannot parse correctly" #1990

Merged
merged 3 commits into from
Apr 17, 2019

Conversation

webknjaz
Copy link
Member

Reverts #1977

Fixes #1973

@webknjaz webknjaz requested a review from decentral1se April 17, 2019 14:37
@webknjaz webknjaz marked this pull request as ready for review April 17, 2019 14:42
@@ -1,5 +1,5 @@
[tox]
minversion = 3.8.6
minversion = 3.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other reviewers, 3.9.0 is the first release of tox that contains the tox-dev/tox#1262 fix

@webknjaz webknjaz requested review from themr0c and ssbarnea April 17, 2019 14:50
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very happy to require such a new tox version but lets go for it.

@webknjaz webknjaz merged commit 3c4ca0d into master Apr 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the revert-1977-cifix/tox-comment-bork-fix branch April 17, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] tox currently doesn't parse deps with comments well
3 participants