Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed migration and vagrant driver #2414

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

ssbarnea
Copy link
Member

Fixes: #2315

@ssbarnea ssbarnea force-pushed the fix/vagrant branch 3 times, most recently from 7e6389b to f34f578 Compare October 27, 2019 15:11
- Configuration migration from v1 to v2 is removed.
- Vagrant driver is removed, as this will be developed externally
  from https://github.com/pycontribs/molecule-vagrant

Fixes: 2315
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
@ssbarnea ssbarnea marked this pull request as ready for review October 28, 2019 11:28
Copy link
Contributor

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@ssbarnea ssbarnea merged commit f013964 into ansible:master Oct 28, 2019
@Miouge1
Copy link

Miouge1 commented Dec 12, 2019

https://github.com/pycontribs/molecule-vagrant is an empty repo at the moment, and no molecule-vagrant project in pypi. Any idea where I can find the project?

@ssbarnea ssbarnea deleted the fix/vagrant branch January 4, 2020 11:05
@westurner
Copy link

westurner commented Feb 5, 2020

Looks like these files didn't make it into https://github.com/ansible-community/molecule-vagrant :

I'm now getting the following errors:

--> Action: 'destroy'
ERROR! the playbook: None could not be found
ERROR: 
--> Action: 'create'
ERROR! the playbook: None could not be found
ERROR: 

[Where] should these be added in molecule-vagrant so that molecule init scenario -d vagrant -s fedora-vagrant works again?

#2315

@westurner
Copy link

And what is the last version before this change was released?

@westurner
Copy link

westurner commented Feb 5, 2020

When I just copy create.yml and destroy.yml from the links above into the scenario directory,

wget 'https://raw.githubusercontent.com/ansible-community/molecule/0cf231a3623e10456fbc21795ae42286ed88e479/molecule/provisioner/ansible/playbooks/vagrant/destroy.yml' 
wget 'https://raw.githubusercontent.com/ansible-community/molecule/0cf231a3623e10456fbc21795ae42286ed88e479/molecule/provisioner/ansible/playbooks/vagrant/create.yml' 

I'm now getting:

ERROR! couldn't resolve module/action 'molecule_vagrant'. This often indicates a misspelling, missing collection, or incorrect module path.

presumably because molecule_vagrant.py is not in https://github.com/ansible-community/molecule-vagrant ?
https://github.com/ansible-community/molecule/blob/0cf231a3623e10456fbc21795ae42286ed88e479/molecule/provisioner/ansible/plugins/modules/molecule_vagrant.py

https://github.com/ansible-community/molecule/pull/2414/files#diff-9b0cc6dd3c61a1aca9b9482e06c74b0f

So, to workaround this with master:

mkdir -p ~/.ansible/plugins/modules  # any dir in ANSIBLE_LIBRARY (as seen in --debug)
cd ~/.ansible/plugins/modules;
wget https://raw.githubusercontent.com/ansible-community/molecule/0cf231a3623e10456fbc21795ae42286ed88e479/molecule/provisioner/ansible/plugins/modules/molecule_vagrant.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins: externalize vagrant driver
4 participants