-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for collections as dependencies #2609
Add support for collections as dependencies #2609
Conversation
Addresses #2466 |
This branch fails in my local environment, but it fails in the same way that master fails for me. So hopefully it won't fail in Zuul. |
f2bf83e
to
76115ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain me why you transformed ansible_galaxy.py into a module? I see a very big number of changes while my impression was that this was more about enabling collections support to the already existing galaxy module.
@ssbarnea Install of collection dependencies requires a completely separate invocation ( Taken all together, I tried to squeeze the changes into the existing file, but it would have required quite a bit of hackery that was very fragile. |
b560977
to
5554a6e
Compare
Just would like to prod again for reviews on this. It's blocking my efforts to create collections that depend on other collections because I can't use Molecule to test. |
I did a brief review and minimal manual testing but due to its size and lack of other reviews, I am going to take a leap-of-faith and let it slip in. I hope I will not regret. @greg-hellings, a big thanks for taking care of this! |
@ssbarnea - I'm not sure how to parse those failures of the gate job. The error is |
Currently tests are failing on Python 2.7 because you can't pip install the necessary openstacksdk module there:
This is causing Python 2.7 tests to fail. It looks like this failure is new as of openstacksdk 0.44 and limiting the install to >=0.15.0,<0.44.0 succeeds. |
OK, the Python 2.7 issue is addressed, now it's seeing this error:
This is beyond my ken and outside of my expertise. |
You just discovered why I proposed dropping py27 yesterday. Two breakages
related to it in a single day. Wait to remove py27 support and recheck
after.
On Fri, 27 Mar 2020 at 04:59, Greg Hellings ***@***.***> wrote:
OK, the Python 2.7 issue is addressed, now it's seeing this error:
2020-03-27 04:31:57.042334 | TASK [ensure-tox : Output tox version]
2020-03-27 04:31:56.807477 | centos-7 | Traceback (most recent call last):
2020-03-27 04:31:56.807700 | centos-7 | File "/usr/bin/tox", line 7, in <module>
2020-03-27 04:31:56.807884 | centos-7 | from tox import cmdline
2020-03-27 04:31:56.808106 | centos-7 | File "/usr/lib/python2.7/site-packages/tox/__init__.py", line 9, in <module>
2020-03-27 04:31:56.808224 | centos-7 | import pluggy
2020-03-27 04:31:56.808454 | centos-7 | File "/usr/lib/python2.7/site-packages/pluggy/__init__.py", line 16, in <module>
2020-03-27 04:31:56.808658 | centos-7 | from .manager import PluginManager, PluginValidationError
2020-03-27 04:31:56.808931 | centos-7 | File "/usr/lib/python2.7/site-packages/pluggy/manager.py", line 11, in <module>
2020-03-27 04:31:56.809075 | centos-7 | import importlib_metadata
2020-03-27 04:31:56.809309 | centos-7 | File "/usr/lib/python2.7/site-packages/importlib_metadata/__init__.py", line 16, in <module>
2020-03-27 04:31:56.809486 | centos-7 | from ._compat import (
2020-03-27 04:31:56.809725 | centos-7 | File "/usr/lib/python2.7/site-packages/importlib_metadata/_compat.py", line 20, in <module>
2020-03-27 04:31:56.809957 | centos-7 | from backports.configparser import ConfigParser
2020-03-27 04:31:56.810166 | centos-7 | ImportError: No module named configparser
2020-03-27 04:31:57.628220 | centos-7 | ERROR
2020-03-27 04:31:57.628439 | centos-7 | {
2020-03-27 04:31:57.628514 | centos-7 | "delta": "0:00:00.064515",
2020-03-27 04:31:57.628576 | centos-7 | "end": "2020-03-27 04:31:56.815348",
2020-03-27 04:31:57.628637 | centos-7 | "msg": "non-zero return code",
2020-03-27 04:31:57.628697 | centos-7 | "rc": 1,
2020-03-27 04:31:57.628783 | centos-7 | "start": "2020-03-27 04:31:56.750833"
2020-03-27 04:31:57.628909 | centos-7 | }
This is beyond my ken and outside of my expertise.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2609 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZAX3CE2ZFAX63YO6DG4LRJQXBDANCNFSM4LG4PT5A>
.
--
--
/sorin
|
@greg-hellings Please rebase it. Sadly by the time I sent it to the gate, the gate was broken due to py27 issues. Now that we removed py27, it should go in easily. |
Enhance the ansible_galaxy dependency to understand collections options in addition to roles directly.
When the current role is part of a collection, set the collection search path for ANSIBLE to the parent collection, so that any playbooks referencing collections within the same namespace can do their job appropriately
006df21
to
6bfea5d
Compare
Rebased. First round of tests are passed. |
Fixes a significant typo in ansible#2609, and adds a test to be sure the error does not creep back in
Enhance the ansible_galaxy dependency to understand collections options
in addition to roles directly.
PR Type