fix broken molecule login #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ansible#3435 Use of ansible runtime prevents of use interactive stdin/stdout, and lack of split causing traces like this: FileNotFoundError: [Errno 2] No such file or directory: '/usr/bin/env /bin/podman exec -e COLUMNS=254 -e LINES=60 -e TERM=bash -e TERM=xterm -ti mariadb_104 bash' (because molecule tries to run whole command line as binary name without arguments). Signed-off-by: George Shuklin <george.shuklin@gmail.com>
amarao
force-pushed
the
fix_molecule_login
branch
from
2288f5d
to
504531b
Compare
src/molecule/command/login.py:29: [F401] 'molecule.app.app' imported but unused Signed-off-by: George Shuklin <george.shuklin@gmail.com>
ssbarnea
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3435
Use of ansible runtime prevents of use interactive stdin/stdout,
and lack of split causing traces like this:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/bin/env /bin/podman exec -e COLUMNS=254 -e LINES=60 -e TERM=bash -e TERM=xterm -ti mariadb_104 bash'
(because molecule tries to run whole command line as binary name
without arguments).