Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ansible-compat from 2.0.2 to 2.1.0 #3560

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Bump ansible-compat from 2.0.2 to 2.1.0 #3560

merged 1 commit into from
Jun 1, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 31, 2022 •
edited by ssbarnea
Loading

This bump also required updating one test as the role installation
location changed from older versions.

@dependabot dependabot bot requested review from a team as code owners May 31, 2022 14:02
@dependabot dependabot bot requested review from Shaps and ziegenberg and removed request for a team May 31, 2022 14:02
@dependabot dependabot bot added dependencies Pull requests that update a dependency file skip-changelog labels May 31, 2022
@dependabot dependabot bot requested review from relrod, ganeshrn and priyamsahoo and removed request for a team May 31, 2022 14:02
@zhan9san
Copy link
Contributor

Let us upgrade ansible-compat in #3514

@ssbarnea ssbarnea force-pushed the dependabot/pip/ansible-compat-2.1.0 branch 2 times, most recently from 3dd3208 to 71834cf Compare May 31, 2022 14:34
@ssbarnea ssbarnea self-assigned this May 31, 2022
@ssbarnea ssbarnea added bug dependencies Pull requests that update a dependency file and removed skip-changelog dependencies Pull requests that update a dependency file labels May 31, 2022
@zhan9san
Copy link
Contributor

zhan9san commented Jun 1, 2022

Hi @ssbarnea

Regarding to the failure of role_list = run_command(["ansible-galaxy", "role", "list"], env=os.environ)

If we run molecule xxx, the role would be installed in an ephemeral directory whose name is calculated by ansible-compat. During molecule xxx, this ephemeral directory is inserted in environment variable ANSIBLE_ROLES_PATH. So all functions work well.

Instead, if we run ansible-galaxy command directly(without molecule), ansible-galaxy has no idea of ephemeral directory, that's to say, the role installed by molecule is unknowable.

This case is covered in #3514

@dependabot @ssbarnea
Bump ansible-compat from 2.0.2 to 2.1.0
957c6fb 
This bump also required updating one test as the role installation
location changed from older versions.
@ssbarnea ssbarnea force-pushed the dependabot/pip/ansible-compat-2.1.0 branch from 71834cf to 957c6fb Compare June 1, 2022 06:51
@ssbarnea ssbarnea merged commit 971a747 into main Jun 1, 2022
@ssbarnea ssbarnea deleted the dependabot/pip/ansible-compat-2.1.0 branch June 1, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaps Shaps Awaiting requested review from Shaps Shaps was automatically assigned from ansible-community/molecule

@ziegenberg ziegenberg Awaiting requested review from ziegenberg ziegenberg was automatically assigned from ansible-community/molecule

@relrod relrod Awaiting requested review from relrod relrod was automatically assigned from ansible-community/devtools

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn was automatically assigned from ansible-community/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

Assignees

@ssbarnea ssbarnea

Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhan9san @ssbarnea