Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update doc on inventory/host section for provisioner #3571

Merged
merged 4 commits into from
Jun 13, 2022

Conversation

amarao
Copy link
Contributor

@amarao amarao commented Jun 1, 2022

  1. Fix incorrect example, as 'hosts' should be two times, first
    time as a name for for 'inventory' section, and second, as
    normal Ansible hosts stanza in the group.

  2. Add well-known fact about incompatibility of sections of
    inventory and links.

@amarao amarao requested review from a team as code owners June 1, 2022 13:50
@amarao amarao requested review from ssbarnea, apatard, ganeshrn and cidrblock and removed request for a team June 1, 2022 13:50
@amarao
Copy link
Contributor Author

amarao commented Jun 1, 2022

Pylint is complaining on command option lines, I hadn't touch those.

@ssbarnea ssbarnea added the bug label Jun 13, 2022
1. Fix incorrect example, as 'hosts' should be two times, first
   time as a name for for 'inventory' section, and second, as
   normal ansible `hosts` stanza in the group.

2. Add well-known fact about incompatibility of sections of
   inventory and links.
@apatard apatard changed the title doc: update doc on inventory/host section for povisioner doc: update doc on inventory/host section for provisioner Jun 13, 2022
Copy link
Contributor

@apatard apatard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad that there's a failure with pylint but since it's not related to this change... Still, I'm surprised that latest commits were getting no errors in the CI.

@apatard apatard mentioned this pull request Jun 13, 2022
@ssbarnea ssbarnea merged commit c562221 into ansible:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants