Add support for custom driver name #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 29, 2022
gciavarrini
force-pushed
the
prefix-custom-driver
branch
from
2eec90b to
7876b45
Compare
This commit adds support for custom driver names starting with `molecule_`, `molecule-`, `custom_`, or `custom-` Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Test if `molecule-`, `molecule_`, `custom-`, `custom_` are valid prefixes as driver name. Test that any other name fails the validation. Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
force-pushed
the
prefix-custom-driver
branch
from
7876b45 to
5672152
Compare
gciavarrini
requested review from
Shaps,
jseguillon,
ssbarnea,
ganeshrn and
shatakshiiii
and removed request for
a team
ssbarnea
approved these changes
Jan 11, 2023
|
Any idea when this PR will be included in a molecule release? The changes to the molecule driver system has broken molecule drivers I maintain: retr0h/molecule-kind#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for using custom driver name.
The proposed solution patches the
molecule.jsonschema to allow driver names starting withmolecule_,molecule-,custom_, orcustom-.This PR adds tests for the proposed feature as well.