Use api to get driver schema file #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opening the PR as draft, since I'd like testing and comments |
Closed
apatard
added a commit
to apatard/molecule-plugins
that referenced
this pull request
Apr 27, 2023
Add molecule vagrant schema json file. Requires ansible/molecule#3898. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
apatard
force-pushed
the
molecule_driver_json
branch
from
491e416 to
e54e87c
Compare
Current code is assuming that the molecule driver are inside a molecule_$driver python resource, which is not the case. For instance, vagrant plugin is in molecule_plugins. As a solution: - extend driver class to provide a schema_file() member, allowing to return a path to the driver.json file, - replace schema_v3 code to use molecule api and get the schema file path thanks to the new schema_file(). Signed-off-by: Arnaud Patard <apatard@hupstream.com>
apatard
requested review from
ssbarnea,
zhan9san,
cidrblock and
priyamsahoo
and removed request for
a team
ssbarnea
approved these changes
Apr 28, 2023
apatard
added a commit
to apatard/molecule-plugins
that referenced
this pull request
Apr 28, 2023
Add molecule vagrant schema json file. Requires ansible/molecule#3898. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
apatard
added a commit
to apatard/molecule-plugins
that referenced
this pull request
Apr 28, 2023
Add molecule vagrant schema json file. Requires ansible/molecule#3898. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
|
Started getting failures today with molecule-podman version 2.0.3 (molecule version 5.0.1): EDIT: nvm, checked referenced issue and CI/CD process was still using molecule-podman instead of molecule-plugins |
apatard
added a commit
to apatard/molecule-plugins
that referenced
this pull request
Jun 26, 2023
Add molecule vagrant schema json file. Requires ansible/molecule#3898. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code is assuming that the molecule driver are inside a molecule_$driver python resource, which is not the case. For instance, vagrant plugin is in molecule_plugins.
As a solution: