Move test folder to project root #4070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianonicolai
force-pushed
the
move
branch
from
142b5cf to
c4229f5
Compare
ssbarnea
requested changes
Oct 18, 2023
|
@ssbarnea can this be merged now? |
|
@cristianonicolai please rebase... |
cristianonicolai
force-pushed
the
move
branch
from
c4229f5 to
afabe9e
Compare
cristianonicolai
force-pushed
the
move
branch
from
afabe9e to
0d671a5
Compare
|
@ssbarnea done :) |
cristianonicolai
force-pushed
the
move
branch
from
0d671a5 to
358bd1c
Compare
|
Double check with molecule-plugins to see if we have any import from molecule.test, if not, feel free to merge it. |
ssbarnea
approved these changes
Nov 13, 2023
audgirka
approved these changes
Nov 13, 2023
Qalthos
previously requested changes
Nov 14, 2023
|
@ssbarnea @Qalthos there is actually only one missing method that we need to add on molecule-plugins to remove the dependency entirely, please take a look on ansible-community/molecule-plugins#206 |
cidrblock
approved these changes
Nov 16, 2023
ssbarnea
dismissed
Qalthos’s stale review
Done and thanks for pointing to it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the test folder into the project's root folder to unify developer experience when onboarding to the project. Other projects such as ansible-lint, pytest-ansible ansible-navigator already follow such structure.