Always apply ssh_connection_options #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always apply ssh_connection_options whether we use identity_file or password.
ssbarnea
approved these changes
Apr 30, 2024
ssbarnea
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always apply
ssh_connection_optionswhether we useidentity_fileor password.Default
ssh_connection_optionsincludeUserKnownHostsFile=/dev/nullandStrictHostKeyChecking=nobut those options are never applied if noidentity_fileparameter is supplied along with the instance config.This pull request changes the default driver to always use
ssh_connection_optionswhetheridentity_fileorpasswordis used.