Update tox.yml #4191
Merged
Update tox.yml #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: ansible/ansible-compat#387 This is why the collection can't be found |
for more information, see https://pre-commit.ci
cidrblock
commented
Jun 5, 2024
| @@ -3,7 +3,7 @@ dependency: | |||
| name: shell | |||
| command: > | |||
| bash -c " | |||
| ansible-galaxy collection install -p '${MOLECULE_EPHEMERAL_DIRECTORY}/collections' community.molecule && | |||
| ansible-galaxy collection install -p '${MOLECULE_EPHEMERAL_DIRECTORY}/collections' community.molecule --force && | |||
There was a problem hiding this comment.
This was added to ensure the collection is installed because the environment is not isolated and the ANSIBLE_COLLECTIONS_PATH not managed when calling with bash. This will force install the collection even if it exists in a standard location.
The following scenarios will have their collection path set to the ephmeral directory by default.
|
no runtime changes, self approving to match the common tox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to shared tox.yml
A couple changes for the tests:
Skip the macos podman and docker test as we don't have podman or docker installed
The
test_command_dependency[dependency-default-shell]fixture was changed to set the collection path for ansible to the directory where the collection is installed.PYTEST_REQPASS will be reintroduced consistently across the board later