Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3.8 back #119

Merged
merged 4 commits into from
May 10, 2023
Merged

Add python 3.8 back #119

merged 4 commits into from
May 10, 2023

Conversation

cidrblock
Copy link
Contributor

In order to test certified collections with ansible 2.9 we need at least python 3.8 support.

This will add python 3.8 back

@cidrblock cidrblock requested a review from a team as a code owner May 9, 2023 18:30
@cidrblock cidrblock requested review from ssbarnea, priyamsahoo, shatakshiiii and a team and removed request for a team May 9, 2023 18:30
@github-actions github-actions bot added the bug label May 9, 2023
This was referenced May 9, 2023
Merged
Merged
Qalthos
Qalthos requested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of these noqas are avoidable

tests/unit/test_unit.py Outdated Show resolved Hide resolved
Qalthos
Qalthos previously requested changes May 9, 2023
View reviewed changes
src/pytest_ansible/module_dispatcher/__init__.py Outdated Show resolved Hide resolved
@cidrblock cidrblock requested a review from Qalthos May 10, 2023 12:32
@cidrblock cidrblock merged commit 18b1947 into ansible:main May 10, 2023
Ruchip16 pushed a commit to Ruchip16/pytest-ansible that referenced this pull request May 18, 2023
@cidrblock @Ruchip16
Add python 3.8 back (ansible#119)
2f68be2 
* Add python 3.8 back

* Fix requirements

* Remove noqa, ruff 38

* 3.8 for GHA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruchip16 Ruchip16 Ruchip16 approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea was automatically assigned from ansible-community/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii was automatically assigned from ansible-community/devtools

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cidrblock @Qalthos @Ruchip16