Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure codevcov is well configured on our projects #169

Closed
10 of 14 tasks
ssbarnea opened this issue Feb 5, 2024 · 0 comments
Closed
10 of 14 tasks

Ensure codevcov is well configured on our projects #169

ssbarnea opened this issue Feb 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Feb 5, 2024

  • codecov token is present in testing git environment (usually named 'test') and we activate it for jobs via environment: test.
  • we use v4 of the uploader with the settings as below:
        uses: codecov/codecov-action@v4
        with:
          name: ${{ matrix.passed_name }}
          token: ${{ secrets.CODECOV_TOKEN }}
          verbose: true
          fail_ci_if_error: true
  • codecov action result is a required action alongside 'check' one, so we do not merge changes that are not blessed by codecov itself. If app does not report status, you might need to go to https://github.com/apps/codecov/installations/398480 and ensure that repository is activated.

  • ensure codecov.yml has the content below:

# codecov.yml
comment: false
coverage:
  status:
    patch: true # we want github annotations

If you see require_ci_to_pass: true in file above, remove it as its true behavior does prevent codecov from reporting the status check even when it should.

Progress

SMEs: Please check your project once you have confirmation that codecov action was updated v4 and that codecov is reporting the status correct on new PRs and that codecov/project is a required check (branch protection).

  • ansible/ansible-compat
  • ansible/ansible-lint
  • ansible/ansible-navigator
  • ansible/ansible-creator
  • ansible/molecule
  • ansible/tox-ansible
  • ansible/pytest-ansible
  • ansible/ansible-development-environment
  • ansible/ansible-dev-tools
  • ansible/creator-ee
@ssbarnea ssbarnea added the bug Something isn't working label Feb 5, 2024
ssbarnea added a commit to ansible/ansible-navigator that referenced this issue Feb 6, 2024
audgirka pushed a commit to ansible/ansible-navigator that referenced this issue Feb 7, 2024
cristianonicolai pushed a commit to ansible/ansible-navigator that referenced this issue Feb 9, 2024
ssbarnea added a commit to ansible/ansible-navigator that referenced this issue Feb 12, 2024
ssbarnea added a commit to ansible/ansible-navigator that referenced this issue Feb 12, 2024
* Review codecov configuration

Related: ansible/team-devtools#169

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant