Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include documentation label to ack workflow #158

Closed
wants to merge 1 commit into from
Closed

Include documentation label to ack workflow #158

wants to merge 1 commit into from

Conversation

cristianonicolai
Copy link
Contributor

No description provided.

@cristianonicolai cristianonicolai requested a review from a team as a code owner December 11, 2023 13:53
@cristianonicolai cristianonicolai requested review from Qalthos and removed request for a team December 11, 2023 13:53
@cristianonicolai cristianonicolai added the enhancement New feature or request label Dec 11, 2023
ssbarnea
ssbarnea requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not going to do this. Documentation should be treated the same way as code, so we need to decide if the change to it counts as patch, minor or major -- or just skip-changelog if is too trivial.

@ssbarnea ssbarnea closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea requested changes

@audgirka audgirka audgirka approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristianonicolai @ssbarnea @audgirka